Add --target flag to update-package-locks.sh - #298
Open
xyos wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Description of Changes
Adds a repeatable
--target <target>flag toscripts/update-package-locks.shso a single build target's package-lock overrides can be regenerated without runningprepare-src+npm installfor all four targets.--target <t>(repeatable): processes only the named target(s). Target names are validated againstconfiguration/*.json; unknown names fail fast with the list of valid targets.generate-oss-attribution.shseparately. Prepared directories are still cleaned up.This shortens the loop when a change only affects one target's lockfiles (for example a dependency override that only needs the sagemaker lock regenerated).
Testing
bash -npasses../scripts/update-package-locks.sh --target bogus-targetexits 1 immediately with the list of valid targets.prepare-src.sh,npm, andgenerate-oss-attribution.shverified all four paths:--target: target processed, attribution skipped with the note, prepared dirs cleaned up;--targetflags: attribution skipped;Screenshots/Videos
Additional Notes
Backporting
Not needed; developer tooling only.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.